angular-ui / ui-grid / 4045

84%

push

travis-ci

fix(build): Cope with tags not conforming to semver format when building. (#6376)

If a developer had defined a git tag which did not conform to the semver format "vx.y.z", the build
process would take this tag and assume it to be the current version but fail when it does not. The
script now skips these tags. It might also make sense to warn about these tags, as the developer may
have had a typo. But this still enforces the pattern to only have tags in that format.

Before this fix, if such a tag had been defined the following error message appeared:
$ grunt
Loading "Gruntfile.js" tasks...ERROR
>> TypeError: Cannot read property 'match' of null

2684 of 4072 branches covered (65.91%)

5628 of 7114 relevant lines covered (79.11%)

414.69 hits per line