• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

tarantool / tarantool / 9335
91%
master: 88%

Build:
Build:
LAST BUILD BRANCH: tests_2Kb
DEFAULT BRANCH: master
Ran 01 Sep 2017 11:23AM UTC
Jobs 1
Files 268
Run time 30s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
9335

push

travis-ci

rtsisyk
alter: commit old index drop and new index create on index rebuild

To rebuild an index when its key def changes, we effectively drop it and
create a new index instead. Skipping Index::commitDrop and commitCreate
stages at this point deprives Vinyl of an opportunity to log the change
in the metadata log and replace the index in the scheduler, which leads
to a crash. This patch adds the commit stage to RebuildIndex which calls
the above-mentioned commitDrop and commitCreate for the old and the new
indexes, respectively.

There is a nuance here. Memtx piggybacks Index::commitDrop to drop space
tuples when the primary index is dropped. This is actually wrong for
tuples belong to a space, not to an index. Besides, it prevents us from
just calling Index::commitDrop() from RebuildIndex::commit() as is,
because RebuildIndex does not modify space data, it just moves space
tuples to a new index. To circumvent this, let us remove commitDrop()
method from MemtxIndex and drop space tuples directly from MemtxSpace's
commitTruncateSpace() and commitAlterSpace().

32522 of 37099 relevant lines covered (87.66%)

1093704.09 hits per line

Jobs
ID Job ID Ran Files Coverage
4 9335.4 (TARGET=coverage) 01 Sep 2017 11:23AM UTC 0
87.66
Travis Job 9335.4
Source Files on build 9335
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #9335
  • c8ac2d90 on github
  • Prev Build on 1.7 (#9308)
  • Next Build on 1.7 (#9336)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc