spulec / moto / 551

95%

Pull #224

travis-ci

Added more complete tags implementation

Tags
===

refactored tags to be able to apply a dictionary of tags as specified in http://docs.aws.amazon.com/AWSEC2/latest/APIReference/ApiReference-query-CreateTags.html

  * create_tags and delete tags validates resource ids
  * create_tags ensures that resources exist prior to tagging
  * fixed delete tag rendering unncessary template
  * Update describe_tags to use filters from querystring

Exceptions
 ======

  * Added InvalidID exception used by CreateTags and DeleteTags per http://docs.aws.amazon.com/AWSEC2/latest/APIReference/api-error-codes.html#InvalidID
  * Added TagLimitExceeded per http://docs.aws.amazon.com/AWSEC2/latest/APIReference/ApiReference-query-CreateTags.html

Models
=====

  * Added validate resource ids method which will throw a InvalidID exception if the resource_id form is incorrect
  * Renamed TaggedEC2Instance object to TaggedEC2Resource, updated all inheritance references.
  * Added TagBackend create_tags method
    * Updated TagBackend create_tags to throw InvalidParameterValueErrorTagNull if a CreateTag key doesn't include a value
    * Updated TagBackend create_tags to throw TagLimitExceeded
  * removed TagBackend create_tag and delete_tag functions
  * Added TagBackend delete_tags method
    * Updated delete_tags method to allow key/value delete per http://docs.aws.amazon.com/AWSEC2/latest/APIReference/ApiReference-query-DeleteTags.html
  * Updated SpotInstanceRequest to allow filter_name 'spot-instance-request-id'
  * Enhanced EC2 Model to allow for checking of if a resource exists based on the resource_id.  This is necessary because tag creations verify that a resource exists prior to performing any action.
  * Updated create_tags method to check if len(tags) > 10 and raise TagLimitExceeded even if the resource doesn't have any tags.
  * Updated TaggedEC2Resource to pass in a proper filter dictionary to describe_tags
  * Updated Instance get_tags to pass in proper filter dic... (continued)

218 of 218 new or added lines in 6 files covered. (100.0%)

6242 of 6436 relevant lines covered (96.99%)

3.72 hits per line