Dica-Developer / gh-review / 405

85%

push

travis-ci

Squashed commit of the following:

commit 606165af9
Merge: c0689cd 86848ce
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Sat Oct 4 22:58:33 2014 +0200

    Merge branch 'refactor/#87' into refactor/#87_2

    Conflicts:
    	app/js/services.js
    	test/unit/servicesSpec.js

commit 86848ce3a
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Sat Oct 4 22:26:06 2014 +0200

    * add menu directive test

commit 474c6a627
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Sat Oct 4 22:25:53 2014 +0200

    * add formatted-date directive test for custom formats

commit 3e0842a04
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Sat Oct 4 22:25:25 2014 +0200

    * add menu directive controller test

commit 287edc27c
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Sat Oct 4 22:25:02 2014 +0200

    * code format

commit dbf333f3e
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Sat Oct 4 21:24:19 2014 +0200

    * define menu directive controller as app controller
      instead inline for better testability

commit ff74ed62c
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Sat Oct 4 20:43:46 2014 +0200

    Add tests for:

    * RootController
    * LoginController

commit eade5f434
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Sat Oct 4 20:43:14 2014 +0200

    * ignore code coverage for ‘WelcomeController’

commit 926c8ac13
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Sat Oct 4 19:51:52 2014 +0200

    * add ‘use strict’

commit 58724da65
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Sat Oct 4 19:51:40 2014 +0200

    * set access token in comment test to avoid github
      lib errors while testing

commit f24a05085
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Sat Oct 4 17:26:59 2014 +0200

    * change filter list state and url

commit eb6c90ac6
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Sat Oct 4 17:06:05 2014 +0200

    * fix storing author in FilterController

commit bed98b051
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Sat Oct 4 13:16:54 2014 +0200

    * fix tests
    * remove CommitListConroller test

commit a9884042d
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Sat Oct 4 12:48:39 2014 +0200

    * add oauth handling to build process

commit d0ff8938d
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Sat Oct 4 12:23:42 2014 +0200

    * use controller for menu directive

commit 15ed3d5ad
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Sat Oct 4 12:23:29 2014 +0200

    * use onEnter handler for all states to check
      if user is authenticated, if not switch state
      to welcome

commit f7254fc4a
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Sat Oct 4 12:22:24 2014 +0200

    * code formatting

commit 6fab2fc8b
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Sat Oct 4 12:22:07 2014 +0200

    * add a welcome state to routes
    * switch to welcome state after logout

commit d4e93c5dc
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Sat Oct 4 12:21:00 2014 +0200

    * combine both menu templates

commit d594a2376
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Fri Oct 3 21:15:48 2014 +0200

    Separate oauth callback handling from main application

    * add oauth callback page
    * remove weird oauth callback handling from root controller
    * change oauth callbck url in options for dev mode

commit d576bad94
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Fri Oct 3 19:02:38 2014 +0200

    * add approved commits to commit list directive

commit d3e58a7ba
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Fri Oct 3 18:41:45 2014 +0200

    * add own controller to commit list directive
    * pass filter and commit list to commit list directive scope

commit 1d21e90e8
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Fri Oct 3 17:33:55 2014 +0200

    * move commit list directive to own file

commit 246eec0e0
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Fri Oct 3 17:27:45 2014 +0200

    * remove obsolte commit list controller

commit be41efb1f
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Fri Oct 3 17:26:15 2014 +0200

    * use html5 conform attribute naming

commit 2dc0332e6
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Fri Oct 3 17:21:48 2014 +0200

    * fix commit list template to work with the new directive

commit e7999398a
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Fri Oct 3 17:20:52 2014 +0200

    Create a directive for the commit list now we can
    reuse the commit list

commit 416803904
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Fri Oct 3 17:19:18 2014 +0200

    * replace the commit list controller and also the commit list template
      with the filter controller and the filter template

commit def7a59a3
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Fri Oct 3 17:18:25 2014 +0200

    * edit and add filter now uses the filter.html template

commit 8aa1d4b63
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Fri Oct 3 17:16:01 2014 +0200

    * remove obsolete module injection from commit header directive

commit 5e0b02c48
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Fri Oct 3 17:15:21 2014 +0200

    * add caching of repositories and branch fetching in service methods

commit 2facc5039
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Fri Oct 3 17:14:02 2014 +0200

    * code formatting

commit 06b79f519
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Fri Oct 3 17:13:23 2014 +0200

    * rename addFilter.html template to filter.html

commit b045d26ab
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Fri Oct 3 17:12:53 2014 +0200

    * add a comment to Filter to investigate commit
      handling if commit has no author attribute

commit 790e337e0
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Fri Oct 3 17:11:33 2014 +0200

    #87 Refactor filter controller

    * filter controller now takes care if we want to
      display an existing Filter or a new one
    * don’t set $scope attributes before every required
      call is done

commit e53bd9a88
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Fri Oct 3 17:08:11 2014 +0200

    * add commit caching for a single page request to filter
    * add methods to get a contributor and a branch list
      of the current repo to filter
    * reset the commit cache every time a change is
      happened to the filter

commit 810ac2b5c
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Fri Oct 3 17:05:05 2014 +0200

    * remove obsolete contributor attribute and it’s
      setter from Filter

commit 4619eaaea
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Fri Oct 3 17:04:03 2014 +0200

    Change the filter factory to be more a provider.
    The Filter provider now initialises a Filter and
    put them into a local cache object. With this we
    avoid to create a new Filter object every time
    we need a Filter. In addition, now we are able to
    use some caching mechanism for commit fetching.

commit 2d545a5c8
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Wed Oct 1 11:03:08 2014 +0200

    * disable sauce labs e2e tests for now

commit eed88fdb7
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Wed Oct 1 11:02:31 2014 +0200

    * use better readable font for commit view

commit 7fcecb9b5
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Wed Oct 1 02:13:04 2014 +0200

    * try sauce labs part3

commit 74cc0ab89
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Wed Oct 1 02:07:39 2014 +0200

    * try source labs part2

commit 388e5dab4
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Wed Oct 1 01:51:30 2014 +0200

    * try source labs part1

commit 2895ac9f8
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Wed Oct 1 01:38:00 2014 +0200

    * fix typo

commit 2d17e7974
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Wed Oct 1 00:44:29 2014 +0200

    * move source credentials to args

commit 1b020b168
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Wed Oct 1 00:39:03 2014 +0200

    * use source labs as testing platform for e2e

commit 7965bdb96
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Wed Oct 1 00:20:04 2014 +0200

    #87

    * enable e2e tests for travis

commit 9af416463
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Wed Oct 1 00:16:17 2014 +0200

    #87

    * enable e2e tests for travis

commit 5f06755d7
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Tue Sep 30 23:51:02 2014 +0200

    * add .tmp folder to .gitignore

commit b0af6a631
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Tue Sep 30 23:50:34 2014 +0200

    #87

    * change global key to vim style

commit 08fcc4f94
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Tue Sep 30 23:50:11 2014 +0200

    * formatting

commit 6f20f7d24
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Tue Sep 30 23:50:02 2014 +0200

    #87

    * fix ‘enter’ key behaviour in commit list if no commit is selected

commit cc4a7f355
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Tue Sep 30 23:49:16 2014 +0200

    #87

    * refactor key navigation in commit list
      set commitPointer initial to -1

commit dd9340e9f
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Tue Sep 30 23:45:11 2014 +0200

    #87

    * refactor dist grunt task
    * use ‘usemin’ grunt task

commit 316608912
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Tue Sep 30 20:17:31 2014 +0200

    #87

    * remove all requirejs dependencies

commit 539b82bdd
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Tue Sep 30 19:42:01 2014 +0200

    #87

    * set coverage reporter back to lcov for travis task

commit cedd803ac
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Tue Sep 30 19:11:17 2014 +0200

    #87

    * remove blank line

commit ba364a136
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Tue Sep 30 19:11:05 2014 +0200

    #87

    * formatting

commit 61f1d1b6c
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Tue Sep 30 19:10:52 2014 +0200

    #87

    * remove obsolete include in service

commit ec3ba8c73
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Tue Sep 30 19:10:16 2014 +0200

    #87

    * add bin poly fill for PhantomJS

commit d5ca1ec60
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Tue Sep 30 18:38:59 2014 +0200

    #87

    * change options.tpl to angular module

commit d7d1dab87
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Tue Sep 30 18:30:59 2014 +0200

    #87

    * adjust karma travis conf
    * change coverage folder

commit 41b438a72
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Tue Sep 30 17:53:40 2014 +0200

    #87

    * rewrite tests to run without requirejs

commit 067c723ea
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Tue Sep 30 15:35:07 2014 +0200

    #87

    * remove requirejs
    * adjust all files and remove define calls

commit 75ef3aa53
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Tue Sep 30 13:27:17 2014 +0200

    #87

    * remove Charts module

commit ff5ceff98
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Tue Sep 30 13:04:51 2014 +0200

    * remove unnecessary hotkey provider config

commit ab672d138
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Tue Sep 30 12:33:54 2014 +0200

    #87

    * add FilterController test file

commit 0abb4d3b9
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Tue Sep 30 12:33:32 2014 +0200

    #87

    * fix e2e tests

commit 9e2cbf4eb
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Tue Sep 30 12:33:20 2014 +0200

    * remove obsolete karma conf file

commit f8ce9af65
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Tue Sep 30 08:19:17 2014 +0200

    #87

    * fix update commits by setting the correct filter since amount

commit 3944b01f7
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Mon Sep 29 23:05:08 2014 +0200

    #87

    * remove double set of filter owner

commit 0fdedac1d
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Mon Sep 29 20:52:51 2014 +0200

    #87

    * extend Filter specs

commit 1e6292a9d
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Mon Sep 29 20:52:30 2014 +0200

    #87

    * set filter.options.meta.isSaved to false manually
      on change author because it doesn’t go through intern
      set method

commit 7ef027549
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Mon Sep 29 20:05:29 2014 +0200

    Revert "Revert "#87""

    This reverts commit <a class=hub.com/Dica-Developer/gh-review/commit/15e047b7abd9d093a8427d3367b952b232d8c03f">15e047b7a.

commit 15e047b7abd9d093a8427d3367b952b232d8c03f
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Mon Sep 29 20:04:18 2014 +0200

    Revert "#87"

    This reverts commit a52a5172a.

commit 5839097dd
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Mon Sep 29 19:58:59 2014 +0200

    #87

    * clean up dependencies

commit 9b9fe4906
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Mon Sep 29 19:58:59 2014 +0200

    #87

    * clean up dependencies

commit 78d07886e
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Mon Sep 29 19:04:32 2014 +0200

    #87 Refactor/Simplify add filter

commit dd63fef66
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Mon Sep 29 19:03:42 2014 +0200

    #87

    * add Filter.getContributorList to get list of contributors (authors)
      for the current repo/branch

commit 078d8f39c
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Mon Sep 29 19:02:43 2014 +0200

    #87

    * add Filter.reset

commit 49e22fab6
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Mon Sep 29 19:02:27 2014 +0200

    #87

    * add Filter.isSaved

commit 7db0133ab
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Mon Sep 29 19:02:06 2014 +0200

    #87

    * distinguish between ’string’ and ‘array’ in Filter.addAuthor

commit e864b9b12
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Mon Sep 29 19:00:42 2014 +0200

    #87

    * disable FilterController spec for now

commit dc06d980c
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Mon Sep 29 19:00:21 2014 +0200

    #87

    * add ‘getAllRepos’ as service
      (fetches all repos with organization and private)
    * add ‘getBranchesForRepo’ as service
    * add appropriated methods to getAllReposAndBranches worker

commit 8da0a1782
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Mon Sep 29 18:57:33 2014 +0200

    * remove unnecessary github user data call when fetching all
      available repos
    * fix tests belong to this service

commit 488995ce8
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Mon Sep 29 18:54:29 2014 +0200

    #87

    * add styling for angular-ui-select as import to main.less

commit bff75ee35
Author: Jörg Weber <weber.joerg.h@gmail.com>
Date:   Mon Sep 29 18:54:00 2014 +0200

    #87

    * add angular-ui-select as dependency
    * add angular-ui-select as app dependency
    * add angular-ui-select to require config

682 of 1313 relevant lines covered (51.94%)

7.74 hits per line