2778

Ran 22 Aug 2017 01:01PM UTC

Jobs 1

Files 84

Run time 4s

Badge

Embed ▾

pending completion

Build # 2778

Build Type

push

travis-ci

Committed by

buger

Commit Message

rpc: make connection ID a local variable

This value is only used in its block, so it need not be a global. But
the problem is that we may call Connect multiple times to force a
re-connect, and the global was getting overwritten while a Dial call was
reading it.

This is the data race that CI caught. Fix it by just making it a local
variable. That way, it's impossible for two distinct Connect calls to
share the same connection ID variable, thus there is no possibility of a
race.

Fixes #987.

Coverage Stats

5971 of 13597 relevant lines covered (43.91%)

0.47 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
2	2778.2 (LATEST_GO=true)	22 Aug 2017 01:01PM UTC	0	43.91	Travis Job 2778.2

Source Files on build 2778

Detailed source file information is not available for this build.

TykTechnologies / tyk / 2778

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2778

TykTechnologies / tyk / 2778

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2778

README BADGES
x