269
77%

Ran 22 Aug 2017 08:36AM UTC

Jobs 1

Files 33

Run time 3s

Badge

Embed ▾

pending completion

Build # 269

Build Type

push

travis-ci

Committed by

ivmai

Commit Message

Fix deadlock in GC_help_marker caused by use of mark_cv of parent process

The marker threads of the parent process are blocked on mark_cv at
fork.  So pthread_cond_wait() malfunction (hang) is possible in the
child process without mark_cv state cleanup (reinitialization).

* pthread_support.c [PARALLEL_MARK] (mark_cv): Move static variable
definition upper to be before GC_start_mark_threads_inner).
* win32_threads.c [GC_PTHREADS_PARAMARK] (mark_cv): Likewise.
* pthread_support.c [PARALLEL_MARK && CAN_HANDLE_FORK] (mark_cv):
Do not initialize statically; add comment.
* win32_threads.c [GC_PTHREADS_PARAMARK && CAN_HANDLE_FORK] (mark_cv):
Likewise.
* pthread_support.c [PARALLEL_MARK && CAN_HANDLE_FORK]
(GC_start_mark_threads_inner): Initialize mark_cv to
PTHREAD_COND_INITIALIZER (unless available_markers_m1 <= 0 or
GC_parallel); add comment.
* win32_threads.c [GC_PTHREADS_PARAMARK && CAN_HANDLE_FORK]
(GC_start_mark_threads_inner): Likewise.
* pthread_support.c [PARALLEL_MARK] (GC_wait_marker,
GC_notify_all_marker): Add assertion that GC_parallel is true (so
mark_cv is initialized).
* win32_threads.c [GC_PTHREADS_PARAMARK] (GC_wait_marker,
GC_notify_all_marker): Likewise.

Run Details

4 of 4 new or added lines in 1 file covered. (100.0%)

4802 of 7289 relevant lines covered (65.88%)

1102461.97 hits per line

Uncovered Existing Lines

Lines	Coverage	File
1	100.0	thread_local_alloc.c
2	100.0	pthread_stop_world.c
3	100.0	malloc.c
14	100.0	headers.c
20	100.0	allchblk.c
32	100.0	reclaim.c
34	100.0	mallocx.c
64	100.0	alloc.c
83	100.0	finalize.c
83	100.0	mark.c
100	100.0	dbg_mlc.c
111	100.0	pthread_support.c
186	100.0	os_dep.c
201	100.0	misc.c

Jobs

ID	Job ID	Ran	Files	Coverage
28	269.28 (CONF_OPTIONS="--enable-gcov --enable-handle-fork --enable-munmap --enable-single-obj-compilation --enable-cplusplus --disable-shared --enable-gc-assertions" CFLAGS_EXTRA="-D NO_INCREMENTAL" REPORT_COVERAGE=true)	22 Aug 2017 08:36AM UTC	0	65.88	Travis Job 269.28

Source Files on build 269

Detailed source file information is not available for this build.

ivmai / bdwgc / 269
77%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 269

ivmai / bdwgc / 269 77%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 269

ivmai / bdwgc / 269
77%

README BADGES
x