9092
91%
master: 87%

Ran 16 Aug 2017 11:45AM UTC

Jobs 1

Files 243

Run time 13s

Badge

Embed ▾

pending completion

Build # 9092

Build Type

push

travis-ci

Committed by

rtsisyk

Commit Message

vinyl: fix assertion in cache add

vinyl_cache_add takes pair of statements - current and previous.
By design, there must be no statements in cache between them.

Some time ago a check was made that the previous statement is in
cache and lays right next to current statement; if that was not
true, the function exited without building a cache chain.
The was wrong because there are some cases when the statement
could be removed by TX finalize/rollback after prepare or even by
cache garbage collector.

Later in this check 'return' was replaced by 'assert' and that
caused rare test crash.

Fix this check. Check only two things 1) absence of entries between
current and previous statements 2) presence of previous statement
if current is already in chain.

Add a test case.

See code comments for details.

Fixes #2685

Run Details

31065 of 35683 relevant lines covered (87.06%)

1109066.69 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
4	9092.4 (TARGET=coverage)	16 Aug 2017 11:45AM UTC	243	87.06	Travis Job 9092.4

Source Files on build 9092

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

tarantool / tarantool / 9092
91%
master: 87%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 9092

tarantool / tarantool / 9092 91% master: 87%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 9092

tarantool / tarantool / 9092
91%
master: 87%

README BADGES
x