PyCQA / pylint / 1410

92%

main: 95%

push

travis-ci

<a href="https://github.com/PyCQA/pylint/commit/<a class=hub.com/PyCQA/pylint/commit/95c14357327c66ec887d3bbf1c92905d4adbb3c0">95c143573<a href="https://github.com/PyCQA/pylint/commit/95c14357327c66ec887d3bbf1c92905d4adbb3c0">&quot;&gt;Do not warn for locally disabled cyclic import checks

Since commit </a><a class="double-link" href="https://github.com/PyCQA/pylint/commit/<a class="double-link" href="https://github.com/PyCQA/pylint/commit/7df8caaa3e1995018417ac2fd87afd89be6945ba">7df8caaa3</a>">7df8caaa3</a><a href="https://github.com/PyCQA/pylint/commit/95c14357327c66ec887d3bbf1c92905d4adbb3c0">,
the &quot;# pylint: disable=cyclic-import&quot; statment is
respected.

One case which was not covered is the disabling of the
check for an import from inside a method/function.

Example:

File test1.py
&gt; class B(object):
&gt;     pass
&gt;
&gt; def function():
&gt;     from . import test2  # pylint: disable=cyclic-import
&gt;     pass

File test2.py
&gt; from . import test1
&gt;
&gt; class A(object):
&gt;     pass

Pylint wrongly reports:
Cyclic import (testfolder.test1 -&gt; testfolder.test2) (cyclic-import)

This is due to the fact that the self._excluded_edges
dict was not filled with the imports that need to be
excluded. Passing the line number to the
self.linter.is_message_enabled() check allows to not
prematurely return due to the line number being None.

Also fixed (with the help of rogalski) the test setup which
got confused by the second 'func' in the test function name

9573 of 10474 relevant lines covered (91.4%)

6.23 hits per line