mbland / custom-links / 425

98%

master: 98%

push

travis-ci

e2e: Eliminate flakiness using webdriver.until

The first end-to-end test case ("creates a new short link") was failing
rather frequently on Travis CI. This attempts to remove the flakiness by
using conditions from `webdriver.until` with `webdriver.wait`, both by
waiting for links to appear before waiting for them to receive focus (in
`waitForActiveLink`) and by using `until.urlIs` to wait for the URL to
change after a click.

Also replaced `https://foo.com/`, etc. with `targetLocation` after
noticing that some failing tests caused the actual `http://baz.com` to
appear.

264 of 290 branches covered (91.03%)

Branch coverage included in aggregate %.

2136 of 2159 relevant lines covered (98.93%)

12.44 hits per line