apollographql / apollo-client / 7014

96%

push

travis-ci

Update lastResult with computed value of currentResult() (#1927)

A pseudo-race condition exists for observable queries that return
a result from currentResult() before setUpQuery() is invoked. The
condition causes a referential equality checks to fail for results
obtained before and after setUpQuery(), despite the results being truly
equal.

This commit stores results computed during currentResults() and
reconfigured queryListenerForObserver() to consult the ObservableQuery
for the lastResult, instead of maintaining a reference within a closure.

1012 of 1147 branches covered (88.23%)

1975 of 2069 relevant lines covered (95.46%)

557.27 hits per line