ionelmc / python-manhole / 217

86%

Pull #23

travis-ci

Add redirect_stderr option

This patch adds a new redirect_stderr option. When set to False, only
sys.stdout is patched and used for condole output. The default value is
True, keeping the current behavior.

Redirecting stderr can cause the console to become unusable becuase
Python is writing errors to stderr when it cannot raise an exception.
For example, during interpeter shutdown, or when code in __del__ method
raises an exception.

For example, in vdsm, we get this error every few seconds:

    Exception RuntimeError: RuntimeError('cannot notify on un-acquired lock',)
    in <module 'threading' from '/usr/lib64/python2.7/threading.pyc'> ignored

While fixing such issues may be possible, it may not be practicle in
large code base. Avoding redirection of stderr allow using manhole in
such case.

16 of 16 new or added lines in 1 file covered. (100.0%)

293 of 302 relevant lines covered (97.02%)

25.3 hits per line