GoogleCloudPlatform / google-cloud-java / 4278

72%

Pull #2283

travis-ci

google-cloud-nio: CloudStorageReadChannel: fix critical bug that could cause the channel position to overflow

This fixes a critical bug in CloudStorageReadChannel in which the channel position
(a long) was getting down-cast to int in CloudStorageReadChannel.innerOpen(). This
could cause the channel position to become negative or a wildly incorrect positive
value if the channel position was greater than MAX_INT.

In practice, this bug would only manifest itself if the channel was constructed with
a non-zero initial position, or if the channel was reopened in response to an error.

Included a test case that fails without the fix, and passes with the fix.

1 of 1 new or added line in 1 file covered. (100.0%)

19862 of 24956 relevant lines covered (79.59%)

46787.98 hits per line