d00rman / restbase / 701

84%

push

travis-ci

Improve filename encoding for PDF responses

- Use quoted string syntax for the plain filename parameter. Protecting
raw `"` remains a TODO that will require new functionality in
hyperswitch. In the meantime, adding quotes already protects many other
chars.
- Correctly pass the mandatory encoding in extended filename syntax.
This avoids Firefox picking up apostrophes in the filename as a
delimiter.

Bug: https://phabricator.wikimedia.org/T171747

828 of 999 branches covered (82.88%)

1538 of 1680 relevant lines covered (91.55%)

148.1 hits per line