952
60%

Ran 26 Jul 2017 03:11PM UTC

Jobs 9

Files 130

Run time 33min

Badge

Embed ▾

pending completion

Build # 952

Build Type

Pull #585

travis-ci

Committed by

web-flow

Commit Message

TTRSS-API: only set auth_info for "Single" ttrss-mode

Currently, newsbeuter sets the HTTP-Auth parameter for all requests that
target the TTRSS-api from the "ttrss-login" and "ttrss-password" config
file options. This explicitly provided auth_info takes precedence over
optionally provided user-information in libcurl.

Therefore the following config settings
    urls-source    "ttrss"
    ttrss-url      "https://htuser:htpasswd@ttrssinstance.example.org"

    ttrss-login    "ttrssuser"
    ttrss-password "ttrsspasswd"

will try to query "trssinstance.example.org" with auth_info
"ttrssuser:ttrsspasswd" and consequently fail, while libcurl as such
would happily accept the auth info from "ttrss-url" when no explicit
auth-info was provided.

This commit rectifies this and consequently allows newsbeuter to use
multiuser-TTRSS instances which are hosted behind http-basic auth.

Pull Request Pull Request #585: TTRSS-API: only set auth_info for "Single" ttrss-mode

Run Details

8 of 8 new or added lines in 1 file covered. (100.0%)

4908 of 13360 relevant lines covered (36.74%)

1026.4 hits per line

New Missed Lines in Diff

Lines	Coverage	∆	File
8	0.0	0.0%	src/ttrss_api.cpp

Uncovered Existing Lines

Lines	Coverage	∆	File
1	0.0	0.0%	src/ttrss_api.cpp

Jobs

ID	Job ID	Ran	Files	Coverage
1	952.1 (COMPILER=g++-4.9 GCOV=/usr/bin/gcov-4.9)	26 Jul 2017 03:13PM UTC	130	35.52	Travis Job 952.1
2	952.2 (COMPILER=g++-5 GCOV=/usr/bin/gcov-5)	26 Jul 2017 03:14PM UTC	130	35.65	Travis Job 952.2
3	952.3 (COMPILER=g++-6 GCOV=/usr/bin/gcov-6)	26 Jul 2017 03:13PM UTC	130	36.29	Travis Job 952.3
4	952.4 (COMPILER=clang++-3.6 GCOV=/usr/bin/gcov)	26 Jul 2017 03:11PM UTC	130	34.54	Travis Job 952.4
5	952.5 (COMPILER=clang++-3.7 GCOV=/usr/bin/gcov)	26 Jul 2017 03:11PM UTC	130	35.98	Travis Job 952.5
6	952.6 (COMPILER=clang++-3.8 GCOV=/usr/bin/gcov)	26 Jul 2017 03:17PM UTC	130	35.98	Travis Job 952.6
7	952.7 (COMPILER=g++ GCOV=/usr/bin/gcov XML_CATALOG_FILES=/usr/local/etc/xml/catalog)	26 Jul 2017 03:38PM UTC	130	36.12	Travis Job 952.7
8	952.8 (COMPILER=clang++ GCOV=/usr/bin/gcov XML_CATALOG_FILES=/usr/local/etc/xml/catalog)	26 Jul 2017 03:44PM UTC	130	36.12	Travis Job 952.8
10	952.10 (COMPILER=clang++-4.0 GCOV=/usr/bin/gcov)	26 Jul 2017 03:21PM UTC	130	35.98	Travis Job 952.10

Source Files on build 952

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

akrennmair / newsbeuter / 952
60%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 952

akrennmair / newsbeuter / 952 60%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 952

akrennmair / newsbeuter / 952
60%

README BADGES
x