Netflix / genie / 1291

94%

push

travis-ci

SLF4J-related fixes (#569)

* Fix misspellings of "intended"

* Utilize parameterized logging and remove calls to toString()
** As suggested in the SLF4J FAQ: https://www.slf4j.org/faq.html#logging_performance
parameterized logging can improve the efficiency of logging calls when
logging at the specified level is disabled.

In addition, per the FAQ: https://www.slf4j.org/faq.html#string_contents
toString() is called automatically.

These changes were suggested and automatically made by SLF4J Helper:
http://plugins.netbeans.org/plugin/72557/

* Also log the IOException
** SLF4J has special support for the last argument to a logger call being
an instance of Throwable: https://www.slf4j.org/faq.html#string_or_object

* Fix two SLF4J logger calls
** There were an inconsistent number of formatting anchors ('{}') which
can cause information not to be logged as expected.

These issues were identified by SLF4J Helper for NetBeans:
http://plugins.netbeans.org/plugin/72557/

20 of 20 new or added lines in 9 files covered. (100.0%)

5600 of 6295 relevant lines covered (88.96%)

0.89 hits per line