838
60%

Ran 21 Jul 2017 04:41PM UTC

Jobs 6

Files 61

Run time 7min

Badge

Embed ▾

pending completion

Build # 838

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Clean up ServerProcess implementation (#341)

Changes the way ServerProcess works so that an individual ServerProcess instance cannot be restarted. If we want to restart a server we stop the existing instance and then create and start a new instance. This means that the new instance will pick up newer configuration if the node configs have been refreshed. This also makes it much more straightforward to manage the lifecycle of ServerProcess instances, because once one stops it will never start again, so it can be removed from the node's instances dict and won't be re-added.

This change also lets us clean up the internals of the ServerProcess implementation, in particular the way it communicates with the subprocess, which should make things much more stable. We move the code to listen for labrad server connect instances into ServerProcess itself, so that the node does not have to keep track of instances to notify in the hacky `instances_to_notify` set, and in addition the ServerProcess can listen for messages only during the time when it cares about messages, namely while attempting to startup.

Fixes #303 
Review: @zchen088

Run Details

4319 of 7141 relevant lines covered (60.48%)

3.62 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	838.1 (SCALABRAD_VERSION=0.8.0)	21 Jul 2017 04:41PM UTC	60.19	Travis Job 838.1
2	838.2 (SCALABRAD_VERSION=0.8.0)	21 Jul 2017 04:41PM UTC	60.41	Travis Job 838.2
3	838.3 (SCALABRAD_VERSION=0.8.0)	21 Jul 2017 04:41PM UTC	60.41	Travis Job 838.3
4	838.4 (SCALABRAD_VERSION=0.8.0)	21 Jul 2017 04:43PM UTC	60.41	Travis Job 838.4
5	838.5 (SCALABRAD_VERSION=0.8.0)	21 Jul 2017 04:43PM UTC	60.41	Travis Job 838.5
6	838.6 (SCALABRAD_VERSION=0.8.0)	21 Jul 2017 04:48PM UTC	60.39	Travis Job 838.6

Source Files on build 838

Detailed source file information is not available for this build.

labrad / pylabrad / 838
60%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 838

labrad / pylabrad / 838 60%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 838

labrad / pylabrad / 838
60%

README BADGES
x