BendingBender / tslint-rules / 149

97%

Pull #21

travis-ci

<a href="https://github.com/BendingBender/tslint-rules/commit/<a class=hub.com/BendingBender/tslint-rules/commit/2427ce5f1ff4ee879131a867750d8a7a54eeb67b">2427ce5f1<a href="https://github.com/BendingBender/tslint-rules/commit/2427ce5f1ff4ee879131a867750d8a7a54eeb67b">&quot;&gt;feat(tslint): use extends instead of rulesDirectory

I misread the README and tried to use extends instead of rulesDirectory in `tslint.json` based on
other tslint config packages I use (tslint-config-prettier, tslint-microsoft-contrib, tslint-react).
This commit changes custom-tslint-rules&amp;#39; configuration to use rulesDirectory internally, which then
allows the user to add &amp;quot;custom-tslint-rules&amp;quot; to the extends property in `tslint.json`.

https://palantir.github.io/tslint/2016/03/31/sharable-configurations-rules.html
https://github.com/palantir/tslint-react/blob/3.0.0/tslint-react.json#L2
https://github.com/alexjoverm/tslint-config-prettier#get-started
https://github.com/Microsoft/tslint-microsoft-contrib/blob/</a><a class="double-link" href="https://github.com/BendingBender/tslint-rules/commit/<a class="double-link" href="https://github.com/BendingBender/tslint-rules/commit/b720cd9827a13c2878d304193544a5b030953ecb">b720cd982</a>">b720cd982</a><a href="https://github.com/BendingBender/tslint-rules/commit/2427ce5f1ff4ee879131a867750d8a7a54eeb67b">/tslint.json#L3

BREAKING CHANGE: this affects how users set up custom-tslint-rules, as they will need to change from
rulesDirectory to extends in their own `tslint.json` confiigurations (as shown in the README), so I
expect this to be a major breaking change (from 3.0.0 to 4.0.0).

94 of 118 branches covered (79.66%)

210 of 217 relevant lines covered (96.77%)

42.6 hits per line