uber / go-torch / 214

95%

push

travis-ci

pprof: fix incorrect parsing for locations (#62)

Fixes #61.

Extrapolating from
https://github.com/google/pprof/blob/master/profile/profile.go#L360 and
https://github.com/uber/go-torch/issues/61 we can have locations of the
following format:

    <id>: 0x<address> M=<mapping id>

Note: This doesn't address all malformed inputs, malformed inputs that
may have gotten through before will still do so. This patch only
addresses #61.

Added the raw pprof out as an additional test for one of our binaries
that failed prior.

pprof: add unit test for location parsing

4 of 4 new or added lines in 1 file covered. (100.0%)

377 of 395 relevant lines covered (95.44%)

3.36 hits per line