Jiri-Kremser / simple-websocket-vcr / 54

97%

Build Type

Pull #7

travis-ci

Committed by Edgar Hernández

Commit Message

Fixes around binary support and reads race conditions

* Ensuring binary data received from websockets is correctly encoded and
  decoded as base64 before storing it.
* Applying ERB substitution only on data that is not binary.
* Fixing a race condition. Calling multiple times "WebsocketVCR.on" was
  causing wait_for_reads to be invoked multiple times creating more
  than one reader thread. This was causing "write" messages to get
  "lost" because if, for example, a cassette has a "read" message followed
  by a "write" message, two reader-threads may "see" the "read" message
  when they "peek" the cassette and, then, both threads will "shift" the
  cassette and the write message will get lost.

Pull Request Pull Request #7:

Run Details

19 of 19 new or added lines in 2 files covered. (100.0%)

477 of 494 relevant lines covered (96.56%)

5.22 hits per line