151
97%

Ran 18 Sep 2014 09:53PM UTC

Jobs 3

Files 6

Run time 2min

Badge

Embed ▾

pending completion

Build # 151

Build Type

Pull #7

travis-ci

Committed by

outoftime

Commit Message

Avoid unnecessarily setting the timeout on the HTTPClient

Any time the timeout setters (e.g. `send_timeout=`) are called on an
`HTTPClient` instance, the [session pool is
cleared](https://github.com/nahi/httpclient/blob/master/lib/httpclient.rb#L302).
This means that every request was inadvertently opening a new connection.

This patch adds some guards to ensure that we only reset the `send_timeout` and
`receive_timeout` in the `ensure` block at the end of the request if doing so
would have an effect. This is only a partial solution—in the case where the
`search_timeout` configuration is used in the client, we'll still be setting
the `timeout`s on the client every request, and thus losing the keepalive.

Pull Request Pull Request #7: Avoid unnecessarily setting the timeout on the HTTPClient

Run Details

139 of 391 relevant lines covered (35.55%)

1.07 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
2	151.2 (2.1.0)	18 Sep 2014 09:54PM UTC	6	35.64	Travis Job 151.2
3	151.3 (2.0.0)	18 Sep 2014 09:53PM UTC	6	35.64	Travis Job 151.3
4	151.4 (1.9.3)	18 Sep 2014 09:54PM UTC	6	35.64	Travis Job 151.4

Source Files on build 151

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

algolia / algoliasearch-client-ruby / 151
97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 151

algolia / algoliasearch-client-ruby / 151 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 151

algolia / algoliasearch-client-ruby / 151
97%

README BADGES
x