1474
82%
master: 81%

Ran 21 Jul 2013 04:47AM UTC

Jobs 5

Files 41

Run time –

Badge

Embed ▾

pending completion

Build # 1474

Build Type

push

travis-ci

Committed by

myronmarston

Commit Message

Convert Metadata to use composition rather than inheritance.

- It's best to avoid subclassing core types like Hash.
- Remove runtime module extensions, since that blows MRIs method
  caches and has an affect on perf.
- Instantiation was a two part process: `.new` followed by `process`.
  Conceptually, these belong together, so switch to using a single
  method for instantiation.

Two gotchas I discovered:

- The `include` matcher didn't initially work properly with `Metadata`.
  It uses an `is_a?(Hash)` check to know how to treat the object.
  To solve this, we override `is_a?` to return true for Hash.
- `dup` didn't work as expected. `dup` is used to get a copy that can be
  modified without affecting the original; however, `dup` was simply
  duping the wrapping object, and each retained a reference to the same
  wrapped hash, causing changes on one to show up on the other. I override
  `dup` and `clone` to address this.

Run Details

1924 of 2342 relevant lines covered (82.15%)

443.79 hits per line

Jobs

ID	Job ID	Ran	Coverage
2	1474.2 (1.9.2)	21 Jul 2013 04:47AM UTC	96.7	Travis Job 1474.2
3	1474.3 (1.9.3)	21 Jul 2013 04:47AM UTC	96.7	Travis Job 1474.3
6	1474.6 (jruby-19mode)	21 Jul 2013 04:47AM UTC	95.15	Travis Job 1474.6
8	1474.8 (rbx-19mode)	21 Jul 2013 04:51AM UTC	82.47	Travis Job 1474.8
9	1474.9 (2.0.0)	21 Jul 2013 04:48AM UTC	96.7	Travis Job 1474.9

Source Files on build 1474

Detailed source file information is not available for this build.

rspec / rspec-core / 1474
82%
master: 81%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1474

rspec / rspec-core / 1474 82% master: 81%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1474

rspec / rspec-core / 1474
82%
master: 81%

README BADGES
x