2543

Ran 06 Jul 2017 03:59PM UTC

Jobs 1

Files 84

Run time 7s

Badge

Embed ▾

pending completion

Build # 2543

Build Type

push

travis-ci

Committed by

buger

Commit Message

all: protect global policies map with a rwmutex

Since reloads will change the map at any point, while other goroutines
may be reading.

And add a test too, to prove that this was an issue and help avoid a
regression.

Race report from the new test, before the fix:

	WARNING: DATA RACE
	Write at 0x0000018a9f78 by goroutine 186:
	  github.com/TykTechnologies/tyk.getPolicies()
	      /home/mvdan/go/src/github.com/TykTechnologies/tyk/main.go:286 +0x437
	  github.com/TykTechnologies/tyk.doReload()
	      /home/mvdan/go/src/github.com/TykTechnologies/tyk/main.go:622 +0x44
	  github.com/TykTechnologies/tyk.TestReloadGlobalRaces()
	      /home/mvdan/go/src/github.com/TykTechnologies/tyk/gateway_test.go:960 +0xe3
	  testing.tRunner()
	      /home/mvdan/tip/src/testing/testing.go:754 +0x16c

	Previous read at 0x0000018a9f78 by goroutine 190:
	  github.com/TykTechnologies/tyk.TestReloadGlobalRaces.func2()
	      /home/mvdan/go/src/github.com/TykTechnologies/tyk/gateway_test.go:957 +0x4f

Coverage Stats

5773 of 13585 relevant lines covered (42.5%)

0.46 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	2543.1 (LATEST_GO=true)	06 Jul 2017 03:59PM UTC	0	42.5	Travis Job 2543.1

Source Files on build 2543

Detailed source file information is not available for this build.

TykTechnologies / tyk / 2543

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2543

TykTechnologies / tyk / 2543

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2543

README BADGES
x