certbot / certbot / 7726

99%

push

travis-ci

Hide exceptions that occur during session.close() (#4891)

* Hide exceptions that occur during session.close()

This fixes #4840. Exceptions that are raised out of __del__ methods are caught
and printed to stderr. By catching any exceptions that occur, we now prevent
this from happening.

Alternative solutions to this would have been either not calling
session.close() at all or adding a close() method to acme.client.ClientNetwork,
acme.client.Client, and certbot.client.Client and using certbot.client.Client
in a context manager to ensure close() is called. The former means that users
of the ACME library never properly close their connections until their program
exits and the latter adds a lot of complexity and nesting of client code for
little benefit.

* Only catch Exceptions

9 of 9 new or added lines in 2 files covered. (100.0%)

20817 of 21069 relevant lines covered (98.8%)

0.99 hits per line