stitchfix / merch_calendar / 91

100%

push

travis-ci

Jmw/fy offset (#13)

* Ignores a few dev env files

* Bumps gem version

* Changes contributors

* Fixes quarter calculation

* Renames DateCalculator to RetailCalendar.  Makes interface more consistent.

Methods on DateCalculator were treating months differently, giving inconsistent
results.  Renamed this class to RetailCalendar to show that it really represents
the NRF 4-5-4 retail calendar.

* Moves month conversion methods

* Makes week methods consistent with month methods

* Adds pry byebug for debugging

* Creates a class for the fiscal year calendar

It's offset the traditional retail calendar by 6 months.  FY
starts in the prior August, as opposed to February.

* Bumps to rc version

* Bumps version in gemfile

* Fixes, tests for backwards compatibility

I confirmed the old behavior through tests, adjusted where necessary, and
deprecated date methods on MerchCalendar singleton.

* Removes configuration that doesn't work

This doesn't work, and modifying a singleton object just
isn't really a good idea.

* Version bump

* Hints at future support of flexible fiscal calendar offsets

* Updates readme with new interfaces.  Removes deprecated things.

* Cleanup: less magic numbers, more documentation!

* Version bump for rc3

* Removes pry dependencies.  They break 1.9.3 support

* Replaces pry, removes pry-byebug

* Tries again to replace pry

* Corrects typo in "offset"

* Misc formatting fixes

* Adds a require that was missing somehow

* Improves grammar about "offset"

105 of 105 new or added lines in 5 files covered. (100.0%)

236 of 242 relevant lines covered (97.52%)

247.39 hits per line