mattupstate / flask-security / 828

28%

push

travis-ci

Fix referrer loop in _get_unauthorized_view().

_get_unauthorized_view() is blindly trying to redirect to the referrer,
without checking if we came from there in the first place. This change
avoids the loops that result from that, by redirecting to `/` if we just
came from the referrer.

A unit test is also provided.

Without this change, the end result is that the browser enters into a
redirect loop, until eventually it goes to the correct place (I haven't
figured out how many; in production we've seen 10s, but in the provided
unit test it only happened 3 times). It also results in multiple
flash messages being printed once the final page is loaded.

4 of 4 new or added lines in 1 file covered. (100.0%)

1349 of 1436 relevant lines covered (93.94%)

5.63 hits per line