tarantool / tarantool / 8541

86%

master: 88%

push

travis-ci

Altering a space takes effect immediately.

Before this patch, the new space, created by alter specification,
would be put into space cache only after successful WAL write.

This behaviour is not linearizable: on a replica, the WAL is
played sequentially, and the order of events could differ from the
master.

Besides, it could crash, as demonstrated in gh-2074 test case.

Since we use a cascading rollback for all transactions on WAL
write error, it's OK to put a space into space cache
before WAL write, so that the new transactions apply to the new
space.

This patch does exsactly that.

All subsequent requests are executed against the new space.

This patch also removes on_replace trigger in the old space, since
all checks against the new tuple format are performed using the new
space.

Fixes #2074.

45 of 45 new or added lines in 1 file covered. (100.0%)

29634 of 34346 relevant lines covered (86.28%)

1090395.33 hits per line