• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

tarantool / tarantool / 8541
86%
master: 88%

Build:
Build:
LAST BUILD BRANCH: gh-10737
DEFAULT BRANCH: master
Ran 05 Jul 2017 04:51AM UTC
Jobs 1
Files 233
Run time 12s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
8541

push

travis-ci

GeorgyKirichenko
Altering a space takes effect immediately.

Before this patch, the new space, created by alter specification,
would be put into space cache only after successful WAL write.

This behaviour is not linearizable: on a replica, the WAL is
played sequentially, and the order of events could differ from the
master.

Besides, it could crash, as demonstrated in gh-2074 test case.

Since we use a cascading rollback for all transactions on WAL
write error, it's OK to put a space into space cache
before WAL write, so that the new transactions apply to the new
space.

This patch does exsactly that.

All subsequent requests are executed against the new space.

This patch also removes on_replace trigger in the old space, since
all checks against the new tuple format are performed using the new
space.

Fixes #2074.

45 of 45 new or added lines in 1 file covered. (100.0%)

29634 of 34346 relevant lines covered (86.28%)

1090395.33 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
11
100.0
src/box/alter.cc

Uncovered Existing Lines

Lines Coverage ∆ File
1
100.0
src/box/vinyl.c
1
100.0
src/box/xlog.cc
1
100.0
src/box/xrow.c
1
100.0
src/lib/small/small/lf_lifo.h
1
100.0
src/lib/small/small/quota.h
2
100.0
src/coio.cc
13
100.0
src/coio_task.c
36
100.0
src/box/alter.cc
Jobs
ID Job ID Ran Files Coverage
4 8541.4 (TARGET=coverage) 05 Jul 2017 04:51AM UTC 0
86.28
Travis Job 8541.4
Source Files on build 8541
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #8541
  • cad38e25 on github
  • Prev Build on gh-2074-update-cach-before-wal-v4 (#8534)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc