reactiflux / discord-irc / 459

97%

main: 97%

Pull #257

travis-ci

Use ircClient.nick instead of nickname when checking current nick

As the irc library can change the nick of the bot when
connecting (e.g. because the nick is currently taken, by
some other user), `this.nickname` may not correspond to the
current nickname and so when receiving a join event upon
joining a channel (prior to the names event), the current
guard against this can pass despite it being an event for
the bot.

This modifies it to check against ircClient.nick where
relevant, and also modifies the test stubs to allow adding
the nickname to the config and exposing this functionality
in tests.

To see the failure before this patch, enable
`ircStatusNotices` and run two copies of the bot; the
second should crash upon joining a channel, as it will have
a modified nickname (e.g. 'testbot1').

146 of 148 branches covered (98.65%)

4 of 4 new or added lines in 1 file covered. (100.0%)

255 of 259 relevant lines covered (98.46%)

57.2 hits per line