824
28%

Ran 29 Jun 2017 04:30PM UTC

Jobs 6

Files 20

Run time 5min

Badge

Embed ▾

pending completion

Build # 824

Build Type

Pull #671

travis-ci

Committed by Nuno Santos

Commit Message

Fix referrer loop in _get_unauthorized_view().

_get_unauthorized_view() is blindly trying to redirect to the referrer,
without checking if we came from there in the first place. This change
avoids the loops that result from that, by redirecting to `/` if we just
came from the referrer.

A unit test is also provided.

Without this change, the end result is that the browser enters into a
redirect loop, until eventually it goes to the correct place (I haven't
figured out how many; in production we've seen 10s, but in the provided
unit test it only happened 3 times). It also results in multiple
flash messages being printed once the final page is loaded.

Fixes #670

Pull Request Pull Request #671:

Run Details

1349 of 1436 relevant lines covered (93.94%)

5.63 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	824.1 (REQUIREMENTS=lowest)	29 Jun 2017 04:31PM UTC	20	93.94	Travis Job 824.1
2	824.2 (REQUIREMENTS=release)	29 Jun 2017 04:31PM UTC	20	93.66	Travis Job 824.2
3	824.3 (REQUIREMENTS=lowest)	29 Jun 2017 04:30PM UTC	20	93.94	Travis Job 824.3
4	824.4 (REQUIREMENTS=release)	29 Jun 2017 04:33PM UTC	20	93.66	Travis Job 824.4
5	824.5 (REQUIREMENTS=lowest)	29 Jun 2017 04:30PM UTC	20	93.94	Travis Job 824.5
6	824.6 (REQUIREMENTS=release)	29 Jun 2017 04:36PM UTC	20	93.66	Travis Job 824.6

Source Files on build 824

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

mattupstate / flask-security / 824
28%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 824

mattupstate / flask-security / 824 28%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 824

mattupstate / flask-security / 824
28%

README BADGES
x