twang2218 / node-cba-netbank / 34

85%

master: 88%

push

travis-ci

Reconstruct the code to be more ES6-ish.

* Use bluebird as Promise library. (for 'longStackShare' debug purpose.)
* Remove dependencies of `collections` and `string`;
* Rename some Account object fields (`nickname` => `name`, `url` => `link`, `bsbNumber` => `bsb`, `accountNumber` => `account`;
* Increase eslint `max-len` to `120`;
* Rename `parseCurrency()` to `parseCurrencyText()`;
* Add `parseCurrencyHtml()`;
* Reconstruct `parseJsonToTransaction()` to `parseTransaction()`;
* Reconstruct `parseTransactions()`;
* Rename `parseAccountKeys()` to `parseAccountListWithKeys()`;
* Rewrite `parseAccountList()`;
* Add `.catch(err)`/print/re-throw section in `.test.js` for better debugging information;

Signed-off-by: Tao Wang <twang2218@gmail.com>

61 of 91 branches covered (67.03%)

156 of 193 relevant lines covered (80.83%)

280.62 hits per line