37
78%

Ran 28 Jun 2017 12:26AM CUT

Jobs 4

Files 9

Run time 59s

Badge

Embed ▾

pending completion

Build # 37

Build Type

Pull #2

travis-ci

Committed by

web-flow

Commit Message

Iternal improvements to Translator

In order to fix/support choice messages, we need access to the message selector. Unfortunately, the selector is private under Symfony's `Translator` class. To circumvent this limitation, we need to define our own selector property and require from the constructor.

Changes:
- Added protected getter for the `LocalesManager` (for subclasses)
- Added setter/getter for the `MessageSelector`
- Added Symfony's `MessageSelector` to the service provider
- Updated `Translator` to use the manager's getter
- Changed visibility to protected for `isValidTranslation()` (for subclasses)
- Fixed choice message in `translateChoice()` and `translationChoice()`

Pull Request Pull Request #2: Translator: Internal improvements

Run Details

324 of 988 relevant lines covered (32.79%)

3.56 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	37.1	28 Jun 2017 12:26AM CUT	41.06	Travis Job 37.1
2	37.2	28 Jun 2017 12:25AM CUT	0.0	Travis Job 37.2
3	37.3	28 Jun 2017 12:25AM CUT	0.0	Travis Job 37.3
4	37.4	28 Jun 2017 12:26AM CUT	0.0	Travis Job 37.4

locomotivemtl / charcoal-translator / 37
78%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 37

locomotivemtl / charcoal-translator / 37 78%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 37

locomotivemtl / charcoal-translator / 37
78%

README BADGES
x