4561
59%

Ran 26 Jun 2017 01:27PM UTC

Jobs 1

Files 129

Run time 6s

Badge

Embed ▾

pending completion

Build # 4561

Build Type

Pull #1550

travis-ci

Committed by

web-flow

Commit Message

Fix broken test in Admin::EventsController

We are using `paper_trail` gem, which saves data in database table
versions. It has a native way to search in the versions records,
using `where_object()` and `where_object_changes()`. They are broken,
under certain conditions. We changed them to a manual `where()`.

To test this case we need: an Event with ID 1, an Event with ID 2, and
a commercial with ID 1, for event with ID 2 - obviously the numbers
could be different as long as there is this matching of IDs. Before
this was made wit ha expect, which would make the test fail if this is
not the case. But this is actually the test case, not what we want to
test, so I moved to the `let`.

This was also the case why one of the test was broken after we change
how the database is cleaned in:

https://github.com/openSUSE/osem/pull/1541

Pull Request Pull Request #1550: Fix broken test in Admin::EventsController

Run Details

3162 of 3671 relevant lines covered (86.13%)

285.03 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	4561.1 (2.2.3, TEST_SUITE=rspec)	01 May 2014 12:13AM UTC	129	86.13	Travis Job 4561.1

Source Files on build 4561

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

openSUSE / osem / 4561
59%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4561

openSUSE / osem / 4561 59%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4561

openSUSE / osem / 4561
59%

README BADGES
x