415
85%

Ran 25 Jun 2017 05:38AM UTC

Jobs 2

Files 8

Run time 2min

Badge

Embed ▾

pending completion

Build # 415

Build Type

Pull #441

travis-ci

Committed by

web-flow

Commit Message

improvements on setAppElement...

There was some pitfalls on how `setAppElement` work.

If your <script /> was in <head />, there was a change that it tries
to use `document.body` that is not yet ready.

Another one was using an selector string that does not find any
elements, causing it to try to perform all call on `null`.

This patch can also help if you want to do server-side rendering,
but this was not tested and, perhaps, it's better to use this function
correctly.

Pull Request Pull Request #441: [fixed] improvements on setAppElement...

Run Details

170 of 287 branches covered (59.23%)

18 of 18 new or added lines in 2 files covered. (100.0%)

302 of 353 relevant lines covered (85.55%)

39.2 hits per line

New Missed Lines in Diff

Lines	Coverage	∆	File
1	93.02	3.37%	src/helpers/ariaAppHider.js

Uncovered Existing Lines

Lines	Coverage	∆	File
1	93.02	3.37%	src/helpers/ariaAppHider.js
4	92.39	0.0%	src/components/Modal.js

Jobs

ID	Job ID	Ran	Files	Coverage
1	415.1	25 Jun 2017 05:38AM UTC	8	85.55	Travis Job 415.1
2	415.2	25 Jun 2017 05:40AM UTC	8	85.55	Travis Job 415.2

Source Files on build 415

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line	Branch Hits	Branch Misses

reactjs / react-modal / 415
85%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 415

reactjs / react-modal / 415 85%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 415

reactjs / react-modal / 415
85%

README BADGES
x