• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

graphql / graphql-js / 2330
98%
master: 98%

Build:
Build:
LAST BUILD BRANCH: directives
DEFAULT BRANCH: master
Ran 22 Jun 2017 06:18AM UTC
Jobs 1
Files 162
Run time 8s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
2330

Pull #927

travis-ci

web-flow
RFC: Descriptions as strings.

As discussed in https://github.com/facebook/graphql/pull/90

This proposes replacing leading comment blocks as descriptions in the schema definition language with leading strings.

While I think there is some reduced ergonomics of using a string literal instead of a comment to write descriptions (unless perhaps you are accustomed to Python or Clojure), there are some compelling advantages:

* Descriptions are first-class in the AST of the schema definition language.
* Comments can remain "ignored" characters.
* No ambiguity between commented out regions and descriptions.

Specific to this reference implementation, since this is a breaking change and comment descriptions in the experimental SDL have fairly wide usage, I've left the comment description implementation intact and allow it to be enabled via an option. This should help with allowing upgrading with minimal impact on existing codebases and aid in automated transforms.
Pull Request #927: RFC: Descriptions as strings.

3461 of 3814 branches covered (90.74%)

141 of 141 new or added lines in 10 files covered. (100.0%)

9002 of 9183 relevant lines covered (98.03%)

1280.44 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
100.0
src/language/parser.js
1
100.0
src/utilities/extendSchema.js

Uncovered Existing Lines

Lines Coverage ∆ File
1
100.0
src/language/parser.js
3
100.0
src/utilities/extendSchema.js
3
100.0
src/utilities/schemaPrinter.js
7
100.0
src/utilities/buildASTSchema.js
Jobs
ID Job ID Ran Files Coverage
1 2330.1 22 Jun 2017 06:18AM UTC 0
98.03
Travis Job 2330.1
Source Files on build 2330
  • Tree
  • List 0
  • Changed 31
  • Source Changed 13
  • Coverage Changed 31
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Repo
  • Travis Build #2330
  • Pull Request #927
  • PR Base - rfc-longstring (#2327)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc