1666
38%

Ran 20 Jun 2017 11:04PM UTC

Jobs 2

Files 237

Run time 35s

Badge

Embed ▾

pending completion

Build # 1666

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Fix races in closing a TcpReaderWriter (#523)

* Fix races in closing a TcpReaderWriter

Each TcpReaderWriter is only accessed by a single thread, but it interleaves
callbacks in ways that aren't safe.  When a TcpInputSubscription or
TcpOutputSubscriber tries to close a TcpReaderWriter, it would only close the
socket, and then let the folly::AsyncSocket callbacks handle the rest in
follow-up events.  Depending on what events are already in the EventBase, we can
run into an inconsistent state.

Fix this by having TcpReaderWriter::close{,Err}() which go through the
{subscriber,subscription,socket}.  They are idempotent, so they are safe to call
in follow-up read{EOF,Err}() events.

Added new test that makes up to 1000 connections in parallel.  Running it
locally without this diff hits CHECK() errors in ~TcpReaderWriter.

* Fix incorrect tests

Of course they leak, we're not synchronizing on the futures before exiting main.
The "RacyFoo" tests aren't valid.

Run Details

7819 of 10647 relevant lines covered (73.44%)

915.82 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
2	1666.2 (GCC_VERSION=4.9 BUILD_TYPE=Debug CPP_VERSION=14 ASAN=On)	20 Jun 2017 11:04PM UTC	237	73.5	Travis Job 1666.2
3	1666.3 (GCC_VERSION=5 BUILD_TYPE=Debug CPP_VERSION=14 ASAN=On)	20 Jun 2017 11:04PM UTC	236	73.9	Travis Job 1666.3

Source Files on build 1666

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

rsocket / rsocket-cpp / 1666
38%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1666

rsocket / rsocket-cpp / 1666 38%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1666

rsocket / rsocket-cpp / 1666
38%

README BADGES
x