Netflix / genie / 1171
89%
master: 94%

LAST BUILD BRANCH: lt_log_failed_dependency
DEFAULT BRANCH: master
Ran
Jobs 1
Files 188
Run time 10s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
1171

push

travis-ci

web-flow 
Improvements to job launch and run script (#534)

Change: swap the order of `setsid` and `sudo` at task launch. This ensure `sudo` is in a different process group than the Genie app [1], as such it will respond to a signal by forwarding it to its children (the run script).
Motivation: a recent `sudo` patch [1] makes sudo not forward signals to its children if the signal comes from a process in the same group.

Change: write genie.done into a different file, and atomically swap it if one does not exist already.
Motivation: if the command completes during handing of a kill signal, it may overwrite the genie.done file created by the kill handler.

Change: use absolute paths for output files created in the `run` script.
Motivation: if a command performs a `pushd` or changes working directory, the `run` script may fail to write output files.

Change: use `kill -0` to check for termination of the child process of the `run` script.
Motivation: the existing solution with `pgrep` was not working on Linux.

Change: increase verbosity of the `run` script.
Motivation: better visibility into what happened at runtime.

Change: disable 'failure' trap once inside the 'kill' trap.
Motivation: the 'failure' has no reason to execute and can override output files.

[1] https://www.sudo.ws/repos/sudo/rev/7ffa2eefd3c0 see also https://stackoverflow.com/questions/34337840/cant-terminate-a-sudo-process-created-with-python-in-ubuntu-15-10/34376188#34376188

5257 of 5922 relevant lines covered (88.77%)

0.89 hits per line

Jobs
ID Job ID Ran Files Coverage
1 1171.1 0
88.77
 Travis Job 1171.1
Source Files on build 1171
Detailed source file information is not available for this build.