ualbertalib / pushmi_pullyu / 235
94%

DEFAULT BRANCH: master
Ran
Jobs 2
Files 21
Run time 3min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
235

push

travis-ci

web-flow 
Code cleanup (#69)

* Fix requires everywhere

* Move custom exceptions to where they are being used

* Code cleanup

* Remove constants, never used anywhere else in codebase

* Simplify code for solr_fetcher

* Cleanup swift depositer and add test for updating deposits

* Already validating noid before we get here in aip.rb no need to do this again

* Cleanup fedora fetcher and make rdf regex return a boolean

* just use instance variable instead of passing it as arguments

* Just pass in fedora fetcher like you do for permissions and solrfetcher and remove local_path args for logging methods as it is always present

* Pass in aip directory instead of making the aip directory from the noid again for log_aip_activity method

* Clean up some tests

* Cleanup AIP creator, mainly no need for destroying files, we do this in aip module

* Update rubocop to latest

* Actually test what fedora fetcher is doing

* Bring swift depositer spec inline with all the other specs

* Refactor AIP module specs, remove error checking on workdir

* Only wrap API call in VCR block and add test for workdir, etc

* Refactor downloader. Remove one off from download_and_log method and use query instead of looping through every graph node for content_filename

* We are depending on RDF, lets include it as a dependency

* order dependencies from A-Z

* Remove sanitizing of noids, could have unexpected effects if we are replacing/manipulating them

* Add specs for solr fetcher class and log_aip_activity method

* Many improvements to aip module, reduce surface area and remove interdependcies of aip classes on it

713 of 760 relevant lines covered (93.82%)

6.5 hits per line

Jobs
ID Job ID Ran Files Coverage
1 235.1 (2.3.3) 0
93.82
 Travis Job 235.1
2 235.2 (2.4.0) 0
93.82
 Travis Job 235.2
Source Files on build 235
Detailed source file information is not available for this build.