ionelmc / python-manhole / 205

86%

Pull #19

travis-ci

Do not modify anything during fork+exec flow

Recently a reinstall_bind_delay was added to avoid binding of unix
socket during fork+exec flow. However the socket is not the only issue
in this flow. Changing process signal mask should not be done, as such
changes may be inherited by the new process. Generally, since we don't
know yet if the manhole is needed, we should do nothing.

This patch changes the semantics of the reinstall_bind_delay so we do
not make any modification to child process (except starting a thread)
until the delay is finished.

The user visible parameter was shortened to "reinstall_delay", as the
user should not be conceded with the internals of the manhole.
Internally the Manhole class call it "setup_delay", as this is the
delay before setting up the manhole.

8 of 8 new or added lines in 1 file covered. (100.0%)

263 of 282 relevant lines covered (93.26%)

24.22 hits per line