brigand / babel-plugin-flow-react-proptypes / 165

93%

push

travis-ci

Fix issue #66 (#99)

* Fix issue #66

Any function containing a react component is considered a functional
React component by isFunctionalReactComponent().

This leads to false positives for functions which just use or generate
instances of React components. These factory functions do not
follow the general contract of react components. In particular, the
first argument to the function may not be props.

It is hard to detect these cases in isFunctionalReactComponent. Instead,
we relax the sanity check in getPropsForTypeAnnotation: if a typeAnnotation
exists but does not have the type we expect, we do not fail hard.
We just don't generate proptypes.

* Add missing changelog for 3.1.2

* Add changelog entry for #66

251 of 271 branches covered (92.62%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

290 of 307 relevant lines covered (94.46%)

98.98 hits per line