vpulim / node-soap / 1299

95%

Pull #933

travis-ci

<a href="https://github.com/vpulim/node-soap/commit/<a class=hub.com/vpulim/node-soap/commit/f71c7def8b8f2086044be690e37f8f4e594451fe">f71c7def8<a href="https://github.com/vpulim/node-soap/commit/f71c7def8b8f2086044be690e37f8f4e594451fe">&quot;&gt;Add test for accepting array as parameter based on wsdl

v. 0.19.0 broke giving array as a parameter. It would now accept the &amp;quot;array&amp;quot;
with invalid syntax like this: {input: {PeriodList: {&amp;quot;PeriodType[]&amp;quot;: {PeriodId: &amp;#39;1&amp;#39;}}}}
i.e. it wants the &amp;quot;[]&amp;quot; as the parameter name and it does not accept an array, but an
object. The invalid syntax then prints invalid XML like this:
&amp;quot;&amp;lt;PeriodList&amp;gt;&amp;lt;PeriodType[]&amp;gt;&amp;lt;PeriodId&amp;gt;1&amp;lt;/PeriodId&amp;gt;&amp;lt;/PeriodType[]&amp;gt;&amp;lt;/PeriodList&gt;&quot;

This test shows old and correct syntax.

This test passes if you revert commit </a><a class="double-link" href="https://github.com/vpulim/node-soap/commit/<a class="double-link" href="https://github.com/vpulim/node-soap/commit/5dbcb1d715843310c799419f260e0962722cd2fb">5dbcb1d71</a>">5dbcb1d71</a><a href="https://github.com/vpulim/node-soap/commit/f71c7def8b8f2086044be690e37f8f4e594451fe">
or disable if statement mentioned in
https://github.com/vpulim/node-soap/pull/914#pullrequestreview-40039598

1114 of 1297 branches covered (85.89%)

1875 of 2012 relevant lines covered (93.19%)

5474.58 hits per line