jquery / jquery-mobile / 2045
86%
master: 43%

LAST BUILD BRANCH: no-prefix
DEFAULT BRANCH: master
Ran
Jobs 17
Files 70
Run time 46min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
2045

push

travis-ci

gabrielschulhof 
Navigation: Correctly (un)escape data-url all throughout the code

Also removes code dealing with nested list URL tokens (subPageUrlKey)

The initial bug was regarding the need to use selector-escaping when looking
for pages inside the DOM via their data-url attribute, because the the data-url
may contain "weird" characters like parantheses, single, and double quotes.

During the process of fixing this it became clear that the data-url attribute
can sometimes end up having a URL-encoded value - but not always. This makes
proper string comparison, much less selector-escaping, impossible. So, it
became necessary to require that data-url never be url-encoded.

Conversely, the URL that ends up in the location when using replaceState() must
be URL-encoded, otherwise, upon deep linking, one may end up with an invalid
URL. For example, if the URL contains an actual percent sign, and the URL is
placed in the location via replaceState(), the percent sign must be URL-encoded
in order for deep-linking to work.

Below are the original commit messages that have been squashed:

Pagecontainer: Escape dataUrl when trying to find page based on it
Navigation: Make sure location is encoded when going to a funky page
Pagecontainer: Test that _find() throws not when looking for weird URLs
Init: Correctly assign data-url for initial page
Init: Make sure "data-url" attribute for initial page is decoded
Pagecontainer: Decode URI when assigning to "data-url" during _parse()
Pagecontainer: Use decoded URL to build selector for data-url
Pagecontainer: Call convertUrlToDataUrl() via _createDataUrl()
Path: Always uri-decode when computing dataUrl
Pagecontainer: Remove extra decoding step, now part of _createDataUrl()

This also removes the possibility that a URL gets double-decoded.
Pagecontainer: Test behavior of _find() in the face of weird URLs
Navigation: Use data-url retrieved from Ajax request in its encoded form
Pagecontainer: Pass encoded URL to $.mobile.navigate()
Init: ... (continued)

3607 of 4245 relevant lines covered (84.97%)

1374.02 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
2
53.33
 -13.33% /home/travis/build/jquery/jquery-mobile/js/navigation/base.js
6
89.72
 -0.1% /home/travis/build/jquery/jquery-mobile/js/navigation/path.js
7
80.24
 -2.13% /home/travis/build/jquery/jquery-mobile/js/widgets/popup.js
14
95.41
 -0.01% /home/travis/build/jquery/jquery-mobile/js/widgets/pagecontainer.js
Jobs
ID Job ID Ran Files Coverage
1 2045.1 (TYPES=unit JQUERIES=1.8.3) 68
73.64
 Travis Job 2045.1
2 2045.2 (TYPES=unit JQUERIES=1.10.2) 68
73.93
 Travis Job 2045.2
3 2045.3 (TYPES=unit JQUERIES=1.11.1) 68
73.59
 Travis Job 2045.3
4 2045.4 (TYPES=unit JQUERIES=2.0.3) 68
73.59
 Travis Job 2045.4
5 2045.5 (TYPES=unit JQUERIES=2.1.1) 68
73.59
 Travis Job 2045.5
6 2045.6 (TYPES=unit JQUERIES=git) 68
73.93
 Travis Job 2045.6
7 2045.7 (TYPES=integration SUITES=!navigation JQUERIES=1.8.3) 59
75.26
 Travis Job 2045.7
8 2045.8 (TYPES=integration SUITES=!navigation JQUERIES=1.10.2) 59
75.53
 Travis Job 2045.8
9 2045.9 (TYPES=integration SUITES=!navigation JQUERIES=1.11.1) 59
75.45
 Travis Job 2045.9
11 2045.11 (TYPES=integration SUITES=!navigation JQUERIES=2.0.3) 59
75.21
 Travis Job 2045.11
12 2045.12 (TYPES=integration SUITES=!navigation JQUERIES=git) 59
75.45
 Travis Job 2045.12
13 2045.13 (TYPES=integration SUITES=navigation JQUERIES=1.8.3) 37
72.29
 Travis Job 2045.13
14 2045.14 (TYPES=integration SUITES=navigation JQUERIES=1.10.2) 37
72.2
 Travis Job 2045.14
15 2045.15 (TYPES=integration SUITES=navigation JQUERIES=1.11.1) 37
72.2
 Travis Job 2045.15
16 2045.16 (TYPES=integration SUITES=navigation JQUERIES=2.1.1) 37
72.2
 Travis Job 2045.16
17 2045.17 (TYPES=integration SUITES=navigation JQUERIES=2.0.3) 37
72.2
 Travis Job 2045.17
18 2045.18 (TYPES=integration SUITES=navigation JQUERIES=git) 37
72.2
 Travis Job 2045.18
Source Files on build 2045
Coverage ∆ File Lines Relevant Covered Missed Hits/Line