7405
99%

Ran 25 May 2017 07:19PM UTC

Jobs 1

Files 171

Run time 9s

Badge

Embed ▾

pending completion

Build # 7405

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Fixes #4719 (#4737)

* Automatically delete temp log file when not used.

This allows close() calls in logging.shutdown() to cause the file to be
deleted when no logging output has been written to the file.

* Make certbot.log.MemoryHandler.flush() a noop.

This causes MemoryHandler.flush() calls in logging.shutdown to be a noop,
allowing us to control when the handler is actually flushed. This prevents log
records from being sent to a temporary file handler for things like
`certbot --version`.

* Keep reference to certbot.log.MemoryHandler.target

In Python 2.7+, the logging module only keeps weak references to created
logging handlers. Because of this, the MemoryHandler's target will not be
properly flushed and closed when logging.shutdown() is called on program exit
unless we keep a reference to it in the MemoryHandler.

* Fixes #4719.

This completes the changes necessary to fix #4719. Now temporary log files are
not created if sys.exit() is called before logging is fully set up. These files
are still created if Certbot crashes for any other reason.

* Document pre_arg_parse_except_hook args.

Coverage Stats

19847 of 20074 relevant lines covered (98.87%)

0.99 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	7405.1 (TOXENV=cover)	25 May 2017 07:19PM UTC	0	98.87	Travis Job 7405.1

Source Files on build 7405

Detailed source file information is not available for this build.

certbot / certbot / 7405
99%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7405

certbot / certbot / 7405 99%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7405

certbot / certbot / 7405
99%

README BADGES
x