Netflix / genie / 1119
89%
master: 94%

LAST BUILD BRANCH: lt_log_failed_dependency
DEFAULT BRANCH: master
Ran
Jobs 1
Files 188
Run time 11s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
1119

push

travis-ci

tgianos 
Display reason when job gets killed by monitor (#507)

* Adding explicit Qualifier to autowired users of ‘jobDir’ resource

Currently this auto wiring works because a single bean of type Resource exists.
Adding qualifier will match by name, so this code won’t break if a second bean of type Resource is introduced.

* Write and read job kill reason file

Motivation:
If a job is killed by JobMonitor, the kill reason is lost and not propagated to the user through the UI, which is confusing.
The reason for this can be summarized as:
1. `JobMonitor` emits a `KillJobEvent` which containing a reason string.
2. `KillJobEvent` is consumed by `JobKillService`, which issues a `kill` command.
3. `JobCompletionServer` eventually detects process termination and updates the database, but the reason is lost.
4. The UI displays the generic "killed" message, which can confuse a user who didn't issue a kill.

Change overview:
Make JobKillService write an extra file `kill-reason` in the job folder, containing the reason for killing as present in the `KillJobEvent`.
`JobCompletionServer` looks for and reads the file before performing the final job database update.

Change content:

* Update interfaces Job{Coordinator,Kill}Service::killJob() to take an extra mandatory “reason” argument
* Introduce JobKillReasonFile to serialize and load job kill reason as JSON
* Pass base working directory as to LocalJobKillService during construction
* Add 'jobsDir' to test services configuration (ServicesConfigTest)
* Introduce new JobStatusMessage class with static constant strings used in job status messages

* Review round 1

* Review round 2

Remove jobsDir Bean added to SericesConfigTest, fix the existing one in GenieCoreTestApplication instead

* Review round 2 (cont)

Add ObjectMapper bean

* Fix indentation

5244 of 5904 relevant lines covered (88.82%)

0.89 hits per line

Jobs
ID Job ID Ran Files Coverage
1 1119.1 0
88.82
 Travis Job 1119.1
Source Files on build 1119
Detailed source file information is not available for this build.