couchbase / cbft / 434

30%

push

travis-ci

windows: hide console as late as possible

platform.HideConsole(true) only has an effect on windows platform, and
before this change, would hide the console (dos box / command prompt)
even before cmd-line parsing was finished.  Meaning any cmd-line
parameter errors wouldn't be shown to the user.

Hiding should only be done after all the cmd-line parsing has finished
and also if the newly introduced CBFT_CONSOLE env var doesn't
otherwise explicitly force the console to "show".

Change-Id: I0cdc165d1
Reviewed-on: http://review.couchbase.org/78332
Well-Formed: Build Bot <build@couchbase.com>
Reviewed-by: Marty Schoch <marty.schoch@gmail.com>
Tested-by: Steve Yen <steve.yen@gmail.com>

4 of 4 new or added lines in 1 file covered. (100.0%)

2079 of 4569 relevant lines covered (45.5%)

19.2 hits per line