29
96%
master: 97%

Ran 19 May 2017 12:23AM UTC

Jobs 3

Files 4

Run time 55s

Badge

Embed ▾

pending completion

Build # 29

Build Type

Pull #17

travis-ci

Committed by

web-flow

Commit Message

Refactor fieldHook function

Summary: I was having a hard time reasoning about the fieldHook function
so I did some refactoring to make it easier to add the embedded struct
fields.

- Remove the in-place data value updates (this appears to have been an
optimization, but, it's not necessary and make the code hard to reason
about)
- Extract getting the updates struct into it's own function.
- Extract getting decodable Struct fields into it's own function.
- Extract applying updates to the srcData into it's own function.
- Rename variables to be more explicit
- Don't use the `from` field, which should be equivalent to
srcData.Type()

Test Plan: tests pass

Pull Request Pull Request #17: Refactor fieldHook function

Run Details

264 of 274 relevant lines covered (96.35%)

3.41 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
4	100.0		hooks.go

Jobs

ID	Job ID	Ran	Coverage
1	29.1	19 May 2017 12:23AM UTC	96.35	Travis Job 29.1
2	29.2	19 May 2017 12:23AM UTC	96.35	Travis Job 29.2
3	29.3	19 May 2017 12:24AM UTC	96.35	Travis Job 29.3

Source Files on build 29

Detailed source file information is not available for this build.

uber-go / mapdecode / 29
96%
master: 97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 29

uber-go / mapdecode / 29 96% master: 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 29

uber-go / mapdecode / 29
96%
master: 97%

README BADGES
x