nats-io / gnatsd / 1349

91%

Pull #493

travis-ci

[FIXED] Authorization Timeout and TLS

When TLS and authorization is enabled, the authorization timeout can
fire during the TLS handshake, causing the server to write the
authorization timeout error string into the client socket, injecting
what becomes bad data into the TLS handshake. This creates misleading
errors on the client such as tls: oversized record received with length
21024.

This moves the authorization timeout scheduling to after the TLS
handshake to avoid the race. This should be safe since TLS has its own
handshake timeout. Added a unit test that fails with the old behavior
and passes with the new. LMK if you can think of a better way to test
this.

Fixes #432

4 of 4 new or added lines in 1 file covered. (100.0%)

4921 of 5409 relevant lines covered (90.98%)

2846.26 hits per line