reactstrap / reactstrap / 856

93%

push

travis-ci

feat(Modal): Support fade and timeout props in the Modal component to allow configuring + disabling of the fade effect (#339)

* Support a fade=false prop in the Modal component

- if fade=false, the following happens:
  - no 'fade' class is applied
  - the modal + backdrop transition timeouts become 0
  - the transitionAppear, etc. booleans passed to Fade are false

* Update fadeless-modal to not use the Fade component

- This feels like a better design. If we are not doing
  a fade effect, why use a Fade component?
- This also gets rid of the usage of TransitionGroup
  when fade={false}.
- Ensure onEnter and onExit fire when expected.

* DRY up shared code between fade-modal and fadeless-modal

- Extract modalDialog rendering into a separate method
- Simplify the variable setting in #renderChildren
  following the movement of several of them into
  #modalDialog

* Make modalTransitionTimeout and backdropTransitionTimeout configurable as props

- Update docs
- Add test

* Fix warning about missing context in DropdownMenu spec

* Allow configuring appear v. enter v. leave timeouts separately

491 of 505 branches covered (97.23%)

1144 of 1145 relevant lines covered (99.91%)

37.12 hits per line