3717
93%

Ran 13 May 2017 10:03PM UTC

Jobs 1

Files 302

Run time 14s

Badge

Embed ▾

pending completion

Build # 3717

Build Type

push

travis-ci

Committed by

blueyed

Commit Message

Fix fullscreen clients with gravity != NorthWest (#1764)

Once upon a time, 4b9584fdb14fc3 already fixed this problem: We have to
set the border width to zero before applying the new geometry to the
client, because changing the border width makes the client move
according to its gravity.

Then came e54387904b16e3 and made this code use awful.placement instead
of just fullscreening the client itself (without explaining why in the
commit message!). After this commit, the border width was just ignored
and left as-is. This was then fixed in 0bf8bb6a64638dec0e (no idea which
callback the commit message refers to, the old code was basically just
c.border_width=0, c:geometry(screen_geo)). However, now the border width
was again changed after the geometry and the bug that was fixed by
4b9584fdb14fc3 was back.

This commit fixes this regression again by making sure that the border
width is set to zero before the geometry is set. This becomes slightly
more complicated, because now it is also awful.placement's job to
restore the old border width.

This is why this commit adds a new option to awful.placement so that it
sets the border width to zero after creating its memento of the old
border width.

Fixes: https://github.com/awesomeWM/awesome/issues/1607
Signed-off-by: Uli Schlachter <psychon@znc.in>

Run Details

15352 of 18787 relevant lines covered (81.72%)

1063.91 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	3717.1 (LUA=5.2 LUANAME=lua5.2 DO_COVERAGE=coveralls)	13 May 2017 10:03PM UTC	0	81.72	Travis Job 3717.1

Source Files on build 3717

Detailed source file information is not available for this build.

awesomeWM / awesome / 3717
93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3717

awesomeWM / awesome / 3717 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3717

awesomeWM / awesome / 3717
93%

README BADGES
x