356
85%

Ran 12 May 2017 01:16PM UTC

Jobs 4

Files 19

Run time 10min

Badge

Embed ▾

pending completion

Build # 356

Build Type

push

travis-ci

Committed by

nalimilan

Commit Message

adjust outer join behavior (types and right outer join bug)

outer joins need to return nullable tables as they may introduce missing
data. similar_nullable on DataTables has been removed (unused) and
replaced with a similar_nullable that works on
NullableCategoricalArrays, and this change is made to support the new
changes to join. The 3 outer joins share a function with inner joins,
and this shared function (compose_joined_table) now performs a check to
see if the join type is :inner, and if so, it will return the same
column type as the parent table rather than promoting to a nullable
column. A bug was found in right-outer join behavior where the values
unique to the right table were added to the table in the incorrect
locations, overwriting data and leaving nulls where they shouldn't be.
This bug, due to incorrect values in rightonly_ixs.join, was fixed by
filling the last n-rows of the datatable where n =
length(rightonly_ixs.join). Tests were checked for accuracy against
pandas.

Run Details

1283 of 1572 relevant lines covered (81.62%)

8726.29 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	356.1	12 May 2017 01:16PM UTC	81.04	Travis Job 356.1
2	356.2	12 May 2017 01:22PM UTC	81.04	Travis Job 356.2
3	356.3	12 May 2017 01:19PM UTC	80.69	Travis Job 356.3
4	356.4	12 May 2017 01:26PM UTC	80.69	Travis Job 356.4

Source Files on build 356

Detailed source file information is not available for this build.

JuliaData / DataTables.jl / 356
85%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 356

JuliaData / DataTables.jl / 356 85%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 356

JuliaData / DataTables.jl / 356
85%

README BADGES
x