• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

sds / haml-lint / 438
100%
main: 97%

Build:
Build:
LAST BUILD BRANCH: dependabot/bundler/rubocop-1.84.1
DEFAULT BRANCH: main
Ran 11 May 2017 11:52AM UTC
Jobs 8
Files 78
Run time 3min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
438

push

travis-ci

trotzig
Fix finding attributes when assigned dynamically

In haml, you can assign attributes dynamically this way:

  %foo{ foo_attributes }

where `foo_attributes` is a method identifier or a variable. With the
newly added InlineStyles linter (619d581), we exposed a dormant bug with
how we look for attributes in a node in tag_node.rb. The following error
would be thrown when trying to lint the above code:

  undefined method `children' for false:HamlLint::ParsedRuby

I applied a somewhat naive fix by just returning early if `children`
isn't there.

Fixes #232

3 of 3 new or added lines in 1 file covered. (100.0%)

1642 of 1645 relevant lines covered (99.82%)

6784.39 hits per line

Jobs
ID Job ID Ran Files Coverage
1 438.1 (2.0, gemfiles/haml4.gemfile) 11 May 2017 11:52AM UTC 0
48.26
Travis Job 438.1
2 438.2 (2.0, gemfiles/haml5.gemfile) 11 May 2017 11:52AM UTC 0
48.26
Travis Job 438.2
3 438.3 (2.1, gemfiles/haml4.gemfile) 11 May 2017 11:52AM UTC 0
99.57
Travis Job 438.3
4 438.4 (2.1, gemfiles/haml5.gemfile) 11 May 2017 11:52AM UTC 0
99.57
Travis Job 438.4
5 438.5 (2.2, gemfiles/haml4.gemfile) 11 May 2017 11:52AM UTC 0
99.57
Travis Job 438.5
6 438.6 (2.2, gemfiles/haml5.gemfile) 11 May 2017 11:54AM UTC 0
99.57
Travis Job 438.6
7 438.7 (2.3.1, gemfiles/haml4.gemfile) 11 May 2017 11:55AM UTC 0
99.57
Travis Job 438.7
8 438.8 (2.3.1, gemfiles/haml5.gemfile) 11 May 2017 11:54AM UTC 0
99.57
Travis Job 438.8
Source Files on build 438
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #438
  • 60293317 on github
  • Next Build on fix-232 (#440)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc