7638
91%
master: 87%

Ran 27 Apr 2017 06:26AM UTC

Jobs 1

Files 222

Run time 14s

Badge

Embed ▾

pending completion

Build # 7638

Build Type

Pull #2390

travis-ci

Committed by

web-flow

Commit Message

net.box: remove varargs from call() and eval()

Change conn:call() and conn:eval() API to accept Lua table instead of
varargs for function/expression arguments:

    conn:call(func_name, arg1, arg2, ...)
      =>
    conn:call(func_name, {arg1, arg2, ...}, opts)

    conn:eval(expr, arg1, arg2, ...)
      =>
    conn:eval(expr, {arg1, arg2, ...}, opts)

This breaking change is needed to extend call() and eval() API with
per-requests options, like `timeout` and `buffer` (see #2195):

    c:call("echo", {1, 2, 3}, {timeout = 0.2})

    c:call("echo", {1, 2, 3}, {buffer = ibuf})
    ibuf.rpos, result = msgpack.ibuf_decode(ibuf.rpos)
    result

Tarantool 1.6.x behaviour can be turned on by `call_16` per-connection option:

    c = net.connect(box.cfg.listen, {call_16 = true})
    c:call('echo', 1, 2, 3)

This is a breaking change for 1.7.x.

Needed for #2285
Closes #2195

Pull Request Pull Request #2390: net.box: remove varargs from call() and eval()

Run Details

28110 of 32225 relevant lines covered (87.23%)

1078702.39 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	95.35	-2.33%	src/lib/small/small/quota.h
1	86.4	-0.8%	src/box/lua/error.cc
1	94.41	-0.62%	src/box/relay.cc
1	75.55	0.0%	src/box/xlog.cc
1	89.11	0.25%	src/box/xrow.cc
1	48.65	-0.34%	src/coio.cc
2	83.83	-0.43%	src/box/index.cc
2	95.93	-0.12%	src/lib/salad/bps_tree.h
3	89.18	-0.05%	src/box/vinyl.c

Jobs

ID	Job ID	Ran	Files	Coverage
4	7638.4 (TARGET=coverage)	27 Apr 2017 06:26AM UTC	222	87.23	Travis Job 7638.4

Source Files on build 7638

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

tarantool / tarantool / 7638
91%
master: 87%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 7638

tarantool / tarantool / 7638 91% master: 87%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 7638

tarantool / tarantool / 7638
91%
master: 87%

README BADGES
x